Skip to content

feat: add DestinationTimestamp to copy options #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat: add DestinationTimestamp to copy options #2730

merged 1 commit into from
Feb 28, 2025

Conversation

aeijdenberg
Copy link
Contributor

Useful for reproducible oci-archive output.

@aeijdenberg
Copy link
Contributor Author

Keen to look at adding an option to buildah to make use of this. This is followup to containers/storage#2259 which has been accepted and merged.

mtrmac
mtrmac requested changes Feb 22, 2025
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Makes sense overall, just a quick note for now to prevent committing us to an API prematurely.

@aeijdenberg aeijdenberg force-pushed the passtimestampoptionthrough branch from cdd5839 to 5c0ffc0 Compare February 23, 2025 07:36
@aeijdenberg aeijdenberg changed the title feat: add CommitTimestamp to copy options feat: add SourceDateEpoch to copy options Feb 23, 2025
mtrmac
mtrmac reviewed Feb 27, 2025
View reviewed changes
@aeijdenberg
feat: add DestinationTimestamp to copy options
57e8568 
Useful for reproducible oci-archive output.

Signed-off-by: Adam Eijdenberg <adam@continusec.com>
@aeijdenberg aeijdenberg force-pushed the passtimestampoptionthrough branch from 5c0ffc0 to 57e8568 Compare February 28, 2025 06:10
@aeijdenberg aeijdenberg changed the title feat: add SourceDateEpoch to copy options feat: add DestinationTimestamp to copy options Feb 28, 2025
mtrmac
mtrmac approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mtrmac mtrmac merged commit 1455d0f into containers:main Feb 28, 2025
10 checks passed
@aeijdenberg aeijdenberg mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeijdenberg @mtrmac