Skip to content

Misc small nits to CI and build #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Misc small nits to CI and build #2573

merged 3 commits into from
Mar 4, 2025

Conversation

kolyshkin
Copy link
Contributor

See individual commits for details.

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM otherwise.

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 4, 2025

@kolyshkin ping?

Since commit 8ca60c5 we use c/storage with devicemapper driver removed,
so libdm_no_deferred_remove is no longer in use.

Remove it.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Instead of excluding just the *.gpg files, let's exclude directories
containing those (and similar) files which should not be subjected
to spell checker.

This makes codespell run faster and fixes the following warning:

> WARNING: Cannot decode file using encoding "utf-8": ./signature/simplesigning/testdata/private-keys-v1.d/A0E6EC3A2963DC2D19E9C24E4E6DD232E6BBE1CD.key
> WARNING: Trying next encoding "iso-8859-1"

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Quite a few phony targets were not marked as such. Fix this.

While at it, let's mark those individually, in place, so it's easier
to remember and check.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

@kolyshkin ping?

My apologies. Updated.

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac mtrmac merged commit 1b336ca into containers:main Mar 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants