list,oci_index: automatically add inbuilt annotations on add #1992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac PTAL |
mtrmac
reviewed
Jun 12, 2023
mtrmac
reviewed
Jun 12, 2023
7d54792 to
1bf94cf
Compare
mtrmac
reviewed
Jun 12, 2023
mtrmac
reviewed
Jun 12, 2023
mtrmac
reviewed
Jun 12, 2023
7b98156 to
e1652f5
Compare
mtrmac
reviewed
Jun 13, 2023
mtrmac
reviewed
Jun 13, 2023
e1652f5 to
a18bee5
Compare
|
@vrothberg @mtrmac PTAL |
mtrmac
reviewed
Jun 14, 2023
mtrmac
reviewed
Jun 14, 2023
17e4957 to
d3ad950
Compare
|
@mtrmac PTAL |
|
@mtrmac Is Anything left pending in this PR ? I have reverted some of the changes, so we can revisit them later once we have minimal working model in place. WDYT ? |
mtrmac
reviewed
Jun 26, 2023
Adding instance to list should automatically add special annotations if any. Signed-off-by: Aditya R <arajan@redhat.com>
d3ad950 to
4cf082a
Compare
mtrmac
approved these changes
Jun 27, 2023
| default: | ||
| return fmt.Errorf("internal error: invalid operation: %d", editInstance.ListOperation) | ||
| } | ||
| } | ||
| if len(addedEntries) != 0 { | ||
| index.Manifests = append(index.Manifests, addedEntries...) | ||
| } | ||
| if len(addedEntries) != 0 || updatedAnnotations { |
There was a problem hiding this comment.
Great catch!
Note for the record: Arguably we should re-sort only on compression annotation change.
But then, we are not computing compression annotations precisely right now (only adding, not deleting), so… we can’t exactly guarantee specific behavior. The two boundary cases (UpdateInstances with no annotation input, and EditInstances adding Zstd) both work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding instance to list should automatically add special annotations if any.