docker: convert fully body to partial requests #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03ab20d to
c998c7c
Compare
|
ready for review |
mtrmac
reviewed
Aug 25, 2021
docker/docker_image_src.go
Outdated
| for _, c := range chunks { | ||
| if c.Offset != currentOffset { | ||
| if c.Offset < currentOffset { | ||
| errs <- errors.New("invalid chunk offset specified") |
There was a problem hiding this comment.
Does anything guarantee the chunks are in increasing, and non-overlapping, offset order? If this is a caller’s responsibility, it needs to be very prominently documented throughout the call stack.
add inline documentation to clarify the expectation for the chunks specified to the GetBlobAt() function. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
ghcr.io converts a multirange request to a 200 response when the client request too much data. If the server replies with a 200 status to a partial request then split the body ignoring any additional content that wasn't requested by the caller. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
c998c7c to
ea19c43
Compare
|
thanks for the review! Pushed a new version |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghcr.io converts a multirange request to a 200 response when the
client request too much data.
If the server replies with a 200 status to a partial request then
split the body ignoring any additional content that wasn't requested
by the caller.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com