Cirrus: Improve test synchronization with c/skopeo #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c760d0 to
1d06cae
Compare
|
Need to wait for containers/skopeo#1249 to merge, than can strip the 'DO NOT MERGE' commit from here. |
The `test_skopeo_task` must be substantially duplicated between this repository and containers/skopeo. Make this easier to maintain by implementing a runner script to contain any/all differences. This allows the `test_skopeo_task` definition to remain 100% identical across the two repositories. Signed-off-by: Chris Evich <cevich@redhat.com>
1d06cae to
8363e0d
Compare
|
This is ready. |
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_skopeo_taskmust be substantially duplicated between thisrepository and containers/skopeo. Make this easier to maintain by
implementing a runner script to contain any/all differences. This
allows the
test_skopeo_taskdefinition to remain 100%identical across the two repositories.
Signed-off-by: Chris Evich cevich@redhat.com