Don't show an ERROR when ignoring a RELEASE message #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RELEASE message is optional anyways, so not handling it is not a critical error that a user needs to worry about. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
lstocchi
reviewed
Aug 7, 2025
We don’t do anything with the message, only print a log, so it’s not really handled, the log would need to indicate the message is ignored or such. I’m fine with "unhandled" for now. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, jandubois The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RELEASE message is optional anyways, so not handling it is not a critical error that a user needs to worry about.
Lima users are getting confused about the error message when they shut down a VM: lima-vm/lima#3776