Upgrade to go '1.23.7' #488
Conversation
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/containers/gvisor-tap-vsock | |||
|
|
|||
| go 1.22.0 | |||
| go 1.23.7 | |||
There was a problem hiding this comment.
Can we stick to 1.23.0? I already don’t like that our dependencies force major go updates on us, I’d prefer to stick to the minimum version possible, and let people building gvisor-tap-vsock use the go version they prefer (ideally the latest released)
| @@ -57,7 +57,7 @@ func init() { | |||
| privateKeyFile = filepath.Join(tmpDir, "id_test") | |||
| publicKeyFile = privateKeyFile + ".pub" | |||
| ignFile = filepath.Join(tmpDir, "test.ign") | |||
| cmdDir = filepath.Join("../cmd") | |||
| cmdDir = "../cmd" | |||
There was a problem hiding this comment.
Can you add the lint error to the commit log so that it’s easier to understand what the problem was?
We need to upgrade to 'go 1.23.0' to be able to upgrade libraries with CVE's, which are requires newer version of go. Also we need disable building packages for fedora 40, as it doesn't have 'go 1.23.0' and will end of life soon. Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Actual error "badCall: suspicious Join on 1 argument (gocritic)
cmdDir = filepath.Join("../cmd")
"
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, evidolob The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4f9db96
into
containers:main
We need to upgrade to 'go 1.23' to be able to upgrade libraries with CVE's, which are requires newer version of go.
Also we need disable building packages for fedora 40, as it doesn't have 'go 1.23' and will end of life soon.