Skip to content

Conversation

vyasgun
Copy link
Member

@vyasgun vyasgun commented Jan 16, 2025

@vyasgun vyasgun force-pushed the pr/gvforwarder-build branch from e78f584 to 18fa67b Compare January 16, 2025 09:08
Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also need to be built and pushed to quay, and to make sure bundles still work with this.

WORKDIR $APP_ROOT/src
COPY . .
RUN make
FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9 AS build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected that changing this line FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9 AS build is enough to fix make image?
I'd use latest rather than a hardcoded version so that we don't need to update it too often.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was running into errors while running the script so I put the fixes.
Changed the tag to latest

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, your changes allow to build from the images directory, eg cd images; podman build .
make image on the other hand attempts to build from the top level directory, not from images.
With your changes, this no longer works.

I'm fine with building from images as long as make image is updated and still works. It would be worth adding a check in github actions that the image can always be built, this does not seem to be tested at the moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you're right - thanks! I changed the Dockerfile.

It would be worth adding a check in github actions that the image can always be built, this does not seem to be tested at the moment.

Something like this? (adding a target in the existing build check) or would it be better to have a separate check?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to the existing build check should be good.

@vyasgun vyasgun force-pushed the pr/gvforwarder-build branch from 18fa67b to 409b6c5 Compare January 21, 2025 07:45
Signed-off-by: Gunjan Vyas <vyasgun20@gmail.com>
@vyasgun vyasgun force-pushed the pr/gvforwarder-build branch 3 times, most recently from 627f949 to 421fe7b Compare January 23, 2025 05:05
Signed-off-by: Gunjan Vyas <vyasgun20@gmail.com>
@vyasgun vyasgun force-pushed the pr/gvforwarder-build branch from 421fe7b to 3dc6f02 Compare January 23, 2025 05:08
@cfergeau
Copy link
Collaborator

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ca73f51 into containers:main Apr 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants