Use fedoraproject published EC2 images #363
Conversation
b1cdd8d to
9863ea5
Compare
|
Looks like this works for x86_64 and arm64. Rawhide support in EC2 is a possibility as well (though not currently needed). Leaving this as a draft until the big question can be answered: "Do/Will we ever need Beta Fedora CI VMs in EC2"? The alternative is migrating the |
|
If I'm understanding this PR correctly, don't you also need to remove all the |
Oh, I thought I had. Maybe I missed committing it or something. In either case, my main quandary is knowing if we really will never again need to incorporate beta CI VM images. If so, I can move this simplification forward. If not, then I need to take the work for my Jira card in another direction. Perhaps this is something I should bring to the team. |
|
Force-push: Commit almost lost Makefile changes. |
|
Once again, I recommend #!/bin/bash
#
# 2024-01-25 esm
#
# FIXME: figure out if this is a PR push or a tag push
#
imgsfx=$(<IMG_SFX)
imgsfx_history=.imgsfx.history
if [[ -e $imgsfx_history ]]; then
if grep -q "$imgsfx" $imgsfx_history; then
echo "FATAL: $imgsfx has already been used" >&2
echo "Please rerun 'make IMG_SFX'" >&2
exit 1
fi
fi
echo $imgsfx >>$imgsfx_history |
|
Sorry for not being clear, this is an experimental PR. It's far from perfect on purpose, I just wanted to see if it was possible to pickup the fedoraproject published AMIs. You're pre-push hook is a neat hack, I wonder if it could be made to work with |
Oh! Actually that's not very hard at all, just a bit of yaml and some minor script changes. Opened #364 |
Signed-off-by: Chris Evich <cevich@redhat.com>
Previously a very complex, manual, and failure-prone `import_images` stage was required to bring raw images into EC2. Primarily this was necessary because beta images aren't published on EC2 by the fedoraproject. However, since the original implementation, CI operations against rawhide have largely supplanted the need to support testing against the beta images. This means the 'import_images' stage can be completely dropped, and the 'base_images' stage can simply source images (including `rawhide` if necessary) published by the Fedora project. Signed-off-by: Chris Evich <cevich@redhat.com>
|
Cirrus CI build successful. Found built image names and IDs:
|
|
|
Great, thanks. Hopefully the new passt (pasta?) package will resolve the old apparmor problem. Giving it a try in containers/podman#23157 |
|
@cevich is this ready to merge? We have a lot of auto-imgs PRs in flight, and I would very much like to get this in, then my local-registry PRs, then the Windows one. |
I guess? I s'pose containers/podman#23157 does show all the Debian tests passing. Since you feel strongly that the PM MacOS failure is a flake, I guess this can go in? I'll un-draft it and let you merge in the order you feel appropriate. |
Previously a very complex, manual, and failure-prone
import_imagesstage was required to bring raw images into EC2. Primarily this was necessary because beta images aren't published on EC2 by the fedoraproject. However, since the original implementation, CI operations against rawhide have largely supplanted the need to support testing against the beta images. This means the 'import_images' stage can be completely dropped, and the 'base_images' stage can simply source images (includingrawhideif necessary) published by the Fedora project.