Revert PR 2202 #2227
Closed
Revert PR 2202 #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa722ef. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
…istry" This reverts commit be7818a. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This reverts commit a376d89. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This reverts commit 3339ddc. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This reverts commit e2324dd. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Nov 4, 2024
containers/common#2227 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
Alternatively, consider merging containers/image#2609 + #2209 . I’d prefer that. Test running in containers/podman#24462 . Or, reverting only aa722ef should be sufficient per my manual testing (but reverting the whole PR as a unit is, of course, entirely fair.) |
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Nov 5, 2024
containers/common#2227 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suspect this is causing issue sin podman as multi arch builds are no longer working as the pulling in parallel seems to break
containers/podman#24447
Draft until we now we will not fix it in time for the 5.3 release and I confirmed this fixes the podman regression