-
Notifications
You must be signed in to change notification settings - Fork 84
Comparing changes
Open a pull request
base repository: containerd/ttrpc
base: v1.2.3
head repository: containerd/ttrpc
compare: v1.2.4
- 10 commits
- 5 files changed
- 5 contributors
Commits on Feb 21, 2024
-
Add optional feature in protobuf compiler
Fixes error "is a proto3 file that contains optional fields, but code generator protoc-gen-go-ttrpc hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional." Signed-off-by: Derek McGowan <derek@mcg.dev>
Configuration menu - View commit details
-
Copy full SHA for 73b6a91 - Browse repository at this point
Copy the full SHA 73b6a91View commit details -
Merge pull request #158 from dmcgowan/update-protobuf
Fix proto3 generation error
Configuration menu - View commit details
-
Copy full SHA for faba589 - Browse repository at this point
Copy the full SHA faba589View commit details
Commits on Feb 29, 2024
-
Update GitHub Actions CI to resolve deprecation warnings
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 589a593 - Browse repository at this point
Copy the full SHA 589a593View commit details -
Merge pull request #161 from austinvazquez/update-ci
Update GitHub Actions CI to resolve deprecation warnings
Configuration menu - View commit details
-
Copy full SHA for 4a2816b - Browse repository at this point
Copy the full SHA 4a2816bView commit details
Commits on Mar 13, 2024
-
Bump google.golang.org/protobuf from 1.31.0 to 1.33.0
Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 272c857 - Browse repository at this point
Copy the full SHA 272c857View commit details
Commits on Apr 19, 2024
-
Bump golang.org/x/net from 0.17.0 to 0.23.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 13b8289 - Browse repository at this point
Copy the full SHA 13b8289View commit details
Commits on May 13, 2024
-
Merge pull request #167 from containerd/dependabot/go_modules/golang.…
…org/x/net-0.23.0 Bump golang.org/x/net from 0.17.0 to 0.23.0
Configuration menu - View commit details
-
Copy full SHA for aa5f2d4 - Browse repository at this point
Copy the full SHA aa5f2d4View commit details -
client: Fix deadlock when writing to pipe blocks
Use sendLock to guard the entire stream allocation + write to wire operation, and streamLock to only guard access to the underlying stream map. This ensures the following: - We uphold the constraint that new stream IDs on the wire are always increasing, because whoever holds sendLock will be ensured to get the next stream ID and be the next to write to the wire. - Locks are always released in LIFO order. This prevents deadlocks. Taking sendLock before releasing streamLock means that if a goroutine blocks writing to the pipe, it can make another goroutine get stuck trying to take sendLock, and therefore streamLock will be kept locked as well. This can lead to the receiver goroutine no longer being able to read responses from the pipe, since it needs to take streamLock when processing a response. This ultimately leads to a complete deadlock of the client. It is reasonable for a server to block writes to the pipe if the client is not reading responses fast enough. So we can't expect writes to never block. I have repro'd the hang with a simple ttrpc client and server. The client spins up 100 goroutines that spam the server with requests constantly. After a few seconds of running I can see it hang. I have set the buffer size for the pipe to 0 to more easily repro, but it would still be possible to hit with a larger buffer size (just may take a higher volume of requests or larger payloads). I also validated that I no longer see the hang with this fix, by leaving the test client/server running for a few minutes. Obviously not 100% conclusive, but before I could get a hang within several seconds of running. Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 1b4f6f8 - Browse repository at this point
Copy the full SHA 1b4f6f8View commit details -
Merge pull request #168 from kevpar/deadlock
client: Fix deadlock when writing to pipe blocks
Configuration menu - View commit details
-
Copy full SHA for ef57342 - Browse repository at this point
Copy the full SHA ef57342View commit details -
Merge pull request #166 from containerd/dependabot/go_modules/google.…
…golang.org/protobuf-1.33.0 Bump google.golang.org/protobuf from 1.31.0 to 1.33.0
Configuration menu - View commit details
-
Copy full SHA for 196dbef - Browse repository at this point
Copy the full SHA 196dbefView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.2.3...v1.2.4