dockerconfig: Add support for creds rotation to docker store #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stargz-snapshotter reads creds from docker store only at startup time. The credentials stored in docker config can get periodically rotated. If stargz-snapshotter is running for extended time on a host before an image is launched the current mechanism fails because rotated creds are not re-read. This patch reads creds file everytime authorizer invokes the 'credentials' function and handles cred rotation. Signed-off-by: Sumeet Bhatia <sumee@amazon.com>
ktock
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stargz-snapshotter reads creds from docker store only at startup time. The
credentials stored in docker config can get periodically rotated.
If stargz-snapshotter is running for extended time on a host before an image is
launched the current mechanism fails because rotated creds are not re-read.
This patch reads creds file everytime authorizer invokes the
'credentials' function and handles cred rotation.
Signed-off-by: Sumeet Bhatia sumee@amazon.com