nydus sn: fix issues with "not found" in CoCo cases. #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 21.39% 21.36% -0.03%
==========================================
Files 122 122
Lines 13617 13632 +15
==========================================
Hits 2913 2913
- Misses 10383 10398 +15
Partials 321 321
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
snapshot/mount_option.go:175
- [nitpick] Consider defining a constant for the fallback source value 'overlayfs' instead of using a hard-coded string, to improve maintainability and readability.
source = "overlayfs"
imeoer
reviewed
Apr 8, 2025
snapshot/mount_option.go
Outdated
| // remains non-empty, a forced assignment is used here. This does not affect the passing of information. | ||
| // it is solely to pass the check. | ||
| if len(source) == 0 { | ||
| source = "overlayfs" |
There was a problem hiding this comment.
How about dummy-image-reference ?
imeoer
reviewed
Apr 8, 2025
snapshot/mount_option.go
Outdated
| @@ -27,6 +27,10 @@ import ( | |||
| "github.com/pkg/errors" | |||
| ) | |||
|
|
|||
| const ( | |||
| KataVirtualVolumeDefaultSource = "overlayfs" | |||
There was a problem hiding this comment.
How about dummy-image-reference ?
To make nydus-snapshotter work well in CoCo: (1) Just go pass when do AddRafsInstance failed. (2) When sn can't get label.CRIImageRef, just assign it with overlayfs. Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
imeoer
approved these changes
Apr 9, 2025
stevenhorsman
added a commit
to kata-containers/kata-containers
that referenced
this pull request
Jun 27, 2025
Bump to version v0.15.2 to pick up fix to mount source in containerd/nydus-snapshotter#636 Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/kata-containers
that referenced
this pull request
Jun 27, 2025
Bump to version v0.15.2 to pick up fix to mount source in containerd/nydus-snapshotter#636 Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make nydus-snapshotter work well in CoCo:
(1) Just go pass when do AddRafsInstance failed.
(2) When sn can't get label.CRIImageRef, just assign it with overlayfs.
Signed-off-by: alex.lyn alex.lyn@antgroup.com