converter: allow controlling referrer with option #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changweige
reviewed
Jul 14, 2023
| // WithReferrer associates a reference to the original OCI manifest. | ||
| // See the `subject` field description in | ||
| // https://github.com/opencontainers/image-spec/blob/main/manifest.md#image-manifest-property-descriptions | ||
| WithReferrer bool |
There was a problem hiding this comment.
Could help introduce why nydus image has to refer to the original OCI image?
There was a problem hiding this comment.
Updated the comment, PTAL.
There was a problem hiding this comment.
Thanks for the update, looks reasonable.
Some registry implementations like Docker Hub don't support the OCI reference type (aka referrer) yet, we shouldn't enable it by default, instead, provide a `WithReferrer` option to control it. With this option, we can track all nydus images associated with an OCI image. For example, in Harbor we can cascade to show nydus images linked to an OCI image, deleting the OCI image can also delete the corresponding nydus images. At runtime, nydus snapshotter can also automatically upgrade an OCI image run to nydus image. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
changweige
approved these changes
Jul 17, 2023
| // WithReferrer associates a reference to the original OCI manifest. | ||
| // See the `subject` field description in | ||
| // https://github.com/opencontainers/image-spec/blob/main/manifest.md#image-manifest-property-descriptions | ||
| WithReferrer bool |
There was a problem hiding this comment.
Thanks for the update, looks reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix dragonflyoss/nydus#1363