Skip to content

commit: Add an option to nerdctl commit command for media type selection #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

commit: Add an option to nerdctl commit command for media type selection #4330

merged 1 commit into from
Jun 23, 2025

Conversation

ChengyuZhu6
Copy link
Member

Fixes: #4329

AkihiroSuda
AkihiroSuda reviewed Jun 20, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jun 20, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jun 20, 2025
View reviewed changes
pkg/api/types/container_types.go Outdated
@@ -385,6 +385,8 @@ type ContainerCommitOptions struct {
Pause bool
// Compression is set commit compression algorithm
Compression CompressionType
// MediaType format of the committed image (docker or oci)
MediaType MediaTypeFormat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the OCI lingo, "MediaType" means strings like application/vnd.oci.image.index.v1+json

https://specs.opencontainers.org/image-spec/media-types/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explaination. I have changed MediaType to ImageFormat. WDYT?

AkihiroSuda
AkihiroSuda reviewed Jun 20, 2025
View reviewed changes
@ChengyuZhu6 ChengyuZhu6 force-pushed the commit-format branch 2 times, most recently from 049f121 to 1e1035b Compare June 23, 2025 06:44
@ChengyuZhu6 ChengyuZhu6 marked this pull request as ready for review June 23, 2025 07:01
This was referenced Jun 23, 2025
Closed
Merged
AkihiroSuda
AkihiroSuda approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 410b0f2 into containerd:main Jun 23, 2025
57 of 58 checks passed
@AkihiroSuda AkihiroSuda added this to the v2.1.3 milestone Jun 23, 2025
@ChengyuZhu6 ChengyuZhu6 deleted the commit-format branch June 25, 2025 02:02
@github-actions github-actions bot mentioned this pull request Jul 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.3
Development

Successfully merging this pull request may close these issues.

Add an option to nerdctl commit command for media type selection
2 participants
@ChengyuZhu6 @AkihiroSuda