Skip to content

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Apr 17, 2025

While test.Case allows declaration of custom environment variables, they must be set during the test declaration, apply to all commands, and cannot be altered during lifecycle operations (eg: Setup). This PR provides the ability to set variables for specific, individual commands.

Use-case seen in #4115

While test allow declaration of custom environment variables, they must be set during the test
declaration, apply to all commands, and cannot be altered during lifecycle operations (eg: Setup).
This provides the ability to set variables for specific, individual commands.

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie marked this pull request as ready for review April 17, 2025 02:04
@apostasie apostasie changed the title Allow per-command environment override [Tigron]: allow per-command environment override Apr 17, 2025
@apostasie
Copy link
Contributor Author

Failure is #4046

apostasie added a commit to apostasie/nerdctl that referenced this pull request Apr 17, 2025
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@AkihiroSuda AkihiroSuda added this to the v2.0.5 milestone Apr 18, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit c3b41b2 into containerd:main Apr 18, 2025
54 of 55 checks passed
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants