[CI] golangci v2: review, fix, document, rules #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is unrelated (#3513 ) |
This was referenced Mar 29, 2025
|
Needs rebase |
- re-activate gocritic, disabling rules we do not pass - disable prealloc (considered harmful) - activate golines formatter - comment and re-orgnize linters section Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Note that QF1009 has been fixed by previous commits working on revive. Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
9be2adc to
46c6af6
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fahedouch @AkihiroSuda
This comes on top of #4048 of course.
#4048 changed almost nothing in code.
This here:
For the first part that actively change code, each fix is a separate commit, so, it should be easy to just drop one if we do not agree that it was necessary:
For the second part, I did organize rules in groups:
I also added the number of occurrences for each failing rule, giving the reader a sense of how much of an effort that would be.
This of course is just my (informed) personal opinion on things, so, happy to change rules to go to different categories based on feedback, so, hit me up.
I also re-enabled gocritic (and disabled prealloc), but have not reviewed its ruleset yet.