Makefile fixes and other spring cleanup #3213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
commented
Jul 12, 2024
|
|
||
| nerdctl: | ||
| $(GO_BUILD) $(GO_BUILD_FLAGS) $(VERBOSE_FLAG) -o $(CURDIR)/_output/nerdctl$(BIN_EXT) $(PACKAGE)/cmd/nerdctl | ||
| $(GO_BUILD) $(GO_BUILD_FLAGS) $(VERBOSE_FLAG) -o $(CURDIR)/_output/nerdctl$(BIN_EXT) ./cmd/nerdctl | ||
|
|
||
| clean: | ||
| find . -name \*~ -delete |
There was a problem hiding this comment.
I am not sure what or why these two are for and if we do need these.
Is that to cleanup leftover files from vi?
Let me know if this should be moved to find $(MAKEFILE_DIR).
AkihiroSuda
reviewed
Jul 14, 2024
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
|
@AkihiroSuda comment addressed (base check removed) - CI is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit removes DOCKER_BUILDKIT references, which have been the default for a while now.
Second commit focuses on the Makefile:
linttasks (golint & yamllint) - and also introducing the use of shellcheckdocker, etc)