-
Notifications
You must be signed in to change notification settings - Fork 689
Darwin build #3763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin build #3763
Conversation
220b297
to
5328c85
Compare
Interesting! Thanks @slonopotamus Is it functional right now? eg: if I share the right folders from a linux VM on a mac, is it "working" enough? |
@slonopotamus would love to see at least some of that to get in. |
Whoops, forgot about this. Will see what can be done... |
Testing now. Seems to build fine. Had to install buildkit and do some configuration so that Currently at this issue:
Looks like runc doesn't support macOS: opencontainers/runc#1733 Will work on that repo I guess and try to port it? |
runc can't and won't run on macOS, it is fully tied to Linux. |
Yeah I realised that pretty quickly… So how is this meant to work then? |
Well, there is a nonzero amount of other runtime shims that could run natively on macOS (though they might not as of today): Note that things these shims run are not a conventional "containers" with Linux userspace in them, but something different. However, And by the way, |
Needs rebase |
be1b8d6
to
eb314f9
Compare
Closes containerd#732 Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
@@ -27,6 +27,8 @@ jobs: | |||
goos: linux | |||
- os: ubuntu-24.04 | |||
goos: freebsd | |||
- os: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ubuntu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just selects a runner. I always was under impression than Linux runner are faster and more available on GitHub Actions. Also, Ubuntu runner is used for Windows lint in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use ubuntu for windows because something is botched wrt Makefile path when on windows...
Will move it to macos-15 - the point is not so much speed here, but verifying that the tooling itself actually works on the target platform.
Making things a bit more clear here: 9c83660
But yeah, it's a detail..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Closes #732