Skip to content

Implement fluentd logging driver #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

Implement fluentd logging driver #1073

merged 1 commit into from
Jun 10, 2022

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented May 21, 2022 •
edited
Loading

Related to #1039

Need to be merged after #1062

@Zheaoli Zheaoli marked this pull request as draft May 21, 2022 12:57
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch 4 times, most recently from fd46946 to 613f706 Compare May 22, 2022 08:23
@Zheaoli Zheaoli marked this pull request as ready for review May 22, 2022 08:24
@Zheaoli Zheaoli changed the title [WIP] Implement fluentd logging driver Implement fluentd logging driver May 22, 2022
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch 3 times, most recently from c1e67ff to b9d0ccd Compare May 22, 2022 08:33
@AkihiroSuda
Copy link
Member

Thanks, but let me mark this as a draft until we review/merge #1062 (sorry for delay in reviewing/merging 🙇 )

@AkihiroSuda AkihiroSuda marked this pull request as draft May 23, 2022 02:05
@Zheaoli
Copy link
Member Author

Zheaoli commented May 23, 2022

Thanks, but let me mark this as a draft until we review/merge #1062 (sorry for delay in reviewing/merging 🙇 )

No problem! Thanks for your work!

@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch from b9d0ccd to be6fe51 Compare June 3, 2022 07:44
@Zheaoli Zheaoli marked this pull request as ready for review June 3, 2022 07:44
@fahedouch fahedouch self-requested a review June 3, 2022 09:30
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch 2 times, most recently from 3a930fa to 994656b Compare June 6, 2022 12:18
AkihiroSuda
AkihiroSuda reviewed Jun 6, 2022
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jun 6, 2022
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jun 6, 2022
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jun 6, 2022
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Jun 6, 2022
View reviewed changes
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch from 994656b to 20c9237 Compare June 7, 2022 02:40
@Zheaoli Zheaoli requested review from AkihiroSuda and ktock June 7, 2022 02:42
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch 3 times, most recently from 27d772a to 6a3a204 Compare June 7, 2022 05:21
fahedouch
fahedouch reviewed Jun 7, 2022
View reviewed changes
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch 5 times, most recently from 0386364 to 791d74d Compare June 7, 2022 13:21
@Zheaoli Zheaoli requested a review from fahedouch June 7, 2022 13:24
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch from 791d74d to 8f0f789 Compare June 8, 2022 15:30
fahedouch
fahedouch reviewed Jun 9, 2022
View reviewed changes
@Zheaoli
Implement fluentd logging driver
8717e4f 
Signed-off-by: Zheao.Li <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/support-fluentd-logging branch from 8f0f789 to 8717e4f Compare June 10, 2022 06:45
@fahedouch
Copy link
Member

Thanks

AkihiroSuda
AkihiroSuda approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 8bf043a into containerd:master Jun 10, 2022
@AkihiroSuda AkihiroSuda added this to the v0.20.1 milestone Jun 10, 2022
@Zheaoli Zheaoli deleted the manjusaka/support-fluentd-logging branch June 10, 2022 16:42
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 12, 2022
Merged
3 tasks
@fahedouch fahedouch mentioned this pull request Jul 12, 2022
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fahedouch fahedouch fahedouch approved these changes

@ktock ktock Awaiting requested review from ktock

Assignees
No one assigned
Labels
area/logging
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Zheaoli @AkihiroSuda @fahedouch @ktock