Skip to content

Move repo to go modules #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2019
Merged

Move repo to go modules #22

merged 2 commits into from
Dec 16, 2019

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 changed the title Add go.mod Move repo to go modules Dec 13, 2019
@chenrui333
Move to go modules
e85a177 
Signed-off-by: Rui Chen <chenrui333@gmail.com>
@chenrui333
Update travis config and build badge
383a85f 
Signed-off-by: Rui Chen <chenrui333@gmail.com>
@chenrui333
Copy link
Contributor Author

Finally, it is passed :)

@estesp
Copy link
Member

estesp commented Dec 14, 2019 •
edited
Loading

It seems like if we really want to move we should be changing go get to go mod vendor (in the .travis.yml script) so it actually uses the new go.mod?

@rcgoodfellow rcgoodfellow mentioned this pull request Dec 14, 2019
Closed
16 tasks
@crosbymichael
Copy link
Member

LGTM

estesp
estesp approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 184a308 into containerd:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @estesp @crosbymichael