Initialize sandbox controller list on CRI server creation #9268
Conversation
Avoid calling out to the client to get a sandbox controller and instead setup the list of controllers on initialization. This fixes a test failure which does not set the client. Signed-off-by: Derek McGowan <derek@mcg.dev>
|
Window 2019
I think we need to change the mingw back to ping @MikeZappa87 @kiashok I'm not familiar with choco. Would you mind fixing this issue? Thanks |
I'll take a look @fuweid |
|
Looks like we have multiple 🔥 at once on CI. I'll merge this PR to fix the majority of jobs (as it fixes Linux integration / MacOS unit tests). Looks like Windows integration has different issue, which can be addressed independently. |
…h upstream containerd/main update fork-external/main branch to upstream containerd/main at commit f90f80d Related work items: containerd#8736, containerd#8861, containerd#8924, containerd#8934, containerd#9027, containerd#9076, containerd#9104, containerd#9118, containerd#9141, containerd#9155, containerd#9177, containerd#9183, containerd#9184, containerd#9186, containerd#9187, containerd#9191, containerd#9200, containerd#9205, containerd#9211, containerd#9214, containerd#9215, containerd#9221, containerd#9223, containerd#9228, containerd#9231, containerd#9234, containerd#9242, containerd#9246, containerd#9247, containerd#9251, containerd#9253, containerd#9254, containerd#9255, containerd#9268
Avoid calling out to the client to get a sandbox controller and instead setup the list of controllers on initialization. This fixes a test failure which does not set the client.