Skip to content

Bump up golangci-lint to v1.54.2 #9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

Bump up golangci-lint to v1.54.2 #9186

merged 2 commits into from
Oct 3, 2023

Conversation

ktock
Copy link
Member

@ktock ktock commented Oct 3, 2023

golangci-lint v1.54.2: https://github.com/golangci/golangci-lint/releases/tag/v1.54.2

This PR also fixes the following linter issues:

content/helpers_test.go:148:5: G601: Implicit memory aliasing in for loop. (gosec)
				&testcase.writer,
				^
metrics/cgroups/v1/oom.go:101:25: G601: Implicit memory aliasing in for loop. (gosec)
		c := atomic.LoadInt64(&t.count)
		                      ^
tracing/plugin/otlp_test.go:77:33: G601: Implicit memory aliasing in for loop. (gosec)
			exp, err := newExporter(ctx, &testcase.input)
			                             ^
pkg/cri/sbserver/images/image_status_test.go:32:2: G101: Potential hardcoded credentials (gosec)
	testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4"
	^
pkg/cri/sbserver/images/service_test.go:38:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
pkg/cri/sbserver/podsandbox/controller_test.go:37:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
metadata/containers_test.go:650:37: G601: Implicit memory aliasing in for loop. (gosec)
			checkContainersEqual(t, &result, &testcase.original, "unexpected result on container update")
			                                 ^
metadata/containers_test.go:666:37: G601: Implicit memory aliasing in for loop. (gosec)
			checkContainersEqual(t, &result, &testcase.expected, "updated failed to get expected result")
			                                 ^
metadata/containers_test.go:673:37: G601: Implicit memory aliasing in for loop. (gosec)
			checkContainersEqual(t, &result, &testcase.expected, "get after failed to get expected result")
			                                 ^
metadata/images_test.go:515:34: G601: Implicit memory aliasing in for loop. (gosec)
			checkImagesEqual(t, &created, &testcase.original, "unexpected image on creation")
			                              ^
metadata/images_test.go:532:34: G601: Implicit memory aliasing in for loop. (gosec)
			checkImagesEqual(t, &updated, &testcase.expected, "updated failed to get expected result")
			                              ^
metadata/images_test.go:540:33: G601: Implicit memory aliasing in for loop. (gosec)
			checkImagesEqual(t, &result, &testcase.expected, "get after failed to get expected result")
			                             ^
pkg/cri/sbserver/test_config.go:27:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
pkg/cri/server/test_config.go:27:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
pkg/cri/server/image_status_test.go:32:2: G101: Potential hardcoded credentials (gosec)
	testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4"
	^

ktock added 2 commits October 3, 2023 21:56
@ktock
Fix linter issues for golangci-lint 1.54.2
6169433 
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@ktock
Bump up golangci-lint to v1.54.2
c85b1d1 
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@estesp estesp merged commit 3a15464 into containerd:main Oct 3, 2023
@ktock ktock deleted the golangci-lint-v1.54.2 branch October 4, 2023 01:28
@estesp estesp mentioned this pull request Dec 1, 2023
Merged
kiashok added a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 8946463: [fork-external/main] Update fork-external/main wit…
ebe5b9b 
…h upstream containerd/main

update fork-external/main branch to upstream containerd/main at commit f90f80d

Related work items: containerd#8736, containerd#8861, containerd#8924, containerd#8934, containerd#9027, containerd#9076, containerd#9104, containerd#9118, containerd#9141, containerd#9155, containerd#9177, containerd#9183, containerd#9184, containerd#9186, containerd#9187, containerd#9191, containerd#9200, containerd#9205, containerd#9211, containerd#9214, containerd#9215, containerd#9221, containerd#9223, containerd#9228, containerd#9231, containerd#9234, containerd#9242, containerd#9246, containerd#9247, containerd#9251, containerd#9253, containerd#9254, containerd#9255, containerd#9268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktock @dmcgowan @estesp