Skip to content

[release/1.7] vendor: update github.com/containerd/nri@v0.4.0 #9099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

[release/1.7] vendor: update github.com/containerd/nri@v0.4.0 #9099

merged 2 commits into from
Sep 15, 2023

Conversation

samuelkarp
Copy link
Member

Cherry-pick of #9088 since NRI is still experimental in 1.7.

@samuelkarp
vendor: update github.com/containerd/nri@v0.4.0
4cd208c 
Signed-off-by: Samuel Karp <samuelkarp@google.com>
(cherry picked from commit 6f9de91)
Signed-off-by: Samuel Karp <samuelkarp@google.com>
@samuelkarp
nri: update mock plugin handlers
3ca015e 
Signed-off-by: Samuel Karp <samuelkarp@google.com>
(cherry picked from commit 9656b8c)
Signed-off-by: Samuel Karp <samuelkarp@google.com>
thaJeztah
thaJeztah approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if we get the "remove containerd dependency" merged, I'd also be "+1" to including that in the 1.7 release (getting that already shipped to reduce circular dependency-hell)

@samuelkarp samuelkarp merged commit beeac35 into containerd:release/1.7 Sep 15, 2023
@dmcgowan dmcgowan mentioned this pull request Oct 5, 2023
Merged
This was referenced Jun 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelkarp @klihub @estesp @thaJeztah