Skip to content

Clean cri options and useless parms #9961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Clean cri options and useless parms #9961

merged 1 commit into from
Mar 19, 2024

Conversation

zhanluxianshen
Copy link
Contributor

/kind cleanup

Clean cri options and useless parms

@k8s-ci-robot
Copy link

Hi @zhanluxianshen. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mxpv mxpv added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@mxpv mxpv added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@zhanluxianshen
Copy link
Contributor Author

Thanks all.
The merge queue ci seems error and block the merge request.

Dose that need me to rebase the branch to main?
@mxpv

@mxpv mxpv added this pull request to the merge queue Mar 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2024
Clean cri options and useless parms
@mxpv
Copy link
Member

mxpv commented Mar 13, 2024

The CI is being flaky lately. Let's give it another try.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
@mxpv mxpv added this pull request to the merge queue Mar 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2024
@zhanluxianshen
Copy link
Contributor Author

merge queue still blocked.
😬😬

@dmcgowan dmcgowan added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@mxpv mxpv added this pull request to the merge queue Mar 19, 2024
Merged via the queue into containerd:main with commit 9a4231d Mar 19, 2024
@zhanluxianshen zhanluxianshen deleted the clean-cri-opts branch March 19, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants