sandbox: update sandbox resource before/after task creation/deletion #9904
Conversation
|
Hi @abel-von. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b8115cd to
4dc8e31
Compare
4dc8e31 to
7fa479a
Compare
7fa479a to
8fae650
Compare
8fae650 to
09004fd
Compare
Signed-off-by: Abel Feng <fshb1988@gmail.com>
cri will call sandbox controller from the sandboxService, remove the dependency of client. Signed-off-by: Abel Feng <fshb1988@gmail.com>
there are two kinds of task, shimTask and sandboxedTask, shimTask is the legacy implementation and compatible with the podsandbox, the sandboxedTask is the task running in the sandbox created by sandbox sontroller v2 Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
09004fd to
eebcd60
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
For sandboxed Task, we call the task api directly into the sandbox. For some kind of sandbox, we may have to update the resources of the sandbox before/after task creation or deletion, and it has to be done outside the sandbox, so we rely on the sandbox controller to update the resources of the sandbox.