Remove duplicated `writeIndex` func #8726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

estesp merged 1 commit into containerd:main from djdongjin:write-content

Jun 23, 2023

Member

djdongjin commented Jun 22, 2023

This PR removes task.writeIndex which is duplicated with the same helper in client.go (writeIndex).

Also move decodeIndex to client.go to collocate it with writeIndex.


          Remove duplicated writeIndex func

2aeac9a

Signed-off-by: Jin Dong <djdongjin95@gmail.com>

thaJeztah approved these changes

View reviewed changes

Member

thaJeztah left a comment

LGTM

cpuguy83 approved these changes

View reviewed changes

dcantah approved these changes

View reviewed changes

estesp approved these changes

View reviewed changes

estesp merged commit 13498a3 into containerd:main

djdongjin deleted the write-content branch

June 23, 2023 01:45

kiashok added a commit to kiashok/containerd that referenced this pull request


          Merged PR 8369437: Update fork-external/main with upstream containerd…

6b2c041

…/main

Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main

Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet