[CRI] Windows Pod Stats: Add a check to skip stats for containers that are not running. #8633
Conversation
|
Hi @jsturtevant. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
33e4700 to
169ea94
Compare
|
/cc @dcantah |
|
Thanks for working on this @jsturtevant ! |
169ea94 to
f054ea4
Compare
When a container is just created, exited state the container will not have stats. A common case for this in k8s is the init containers for a pod. The will be present in the listed containers but will not have a running task and there for no stats. Signed-off-by: James Sturtevant <jstur@microsoft.com>
f054ea4 to
28a5199
Compare
…/main Merge upstream containerd/main at commit 5d1ab01 into ado fork-external/main Related work items: containerd#7944, containerd#8174, containerd#8334, containerd#8362, containerd#8572, containerd#8582, containerd#8588, containerd#8605, containerd#8606, containerd#8617, containerd#8619, containerd#8626, containerd#8627, containerd#8633, containerd#8637, containerd#8641, containerd#8643, containerd#8645, containerd#8652, containerd#8667, containerd#8672, containerd#8673, containerd#8676, containerd#8680, containerd#8684, containerd#8685, containerd#8692, containerd#8696, containerd#8697, containerd#8701, containerd#8708, containerd#8717, containerd#8726, containerd#8728, containerd#8729, containerd#8731, containerd#8732, containerd#8740, containerd#8752, containerd#8758, containerd#8762, containerd#8764
When a container is just created, exited state the container will not have stats. A common case for this in k8s is the init containers for a pod. They will be present in the listed containers but will not have a running task and there for no stats.
other information
This type of check to prevent querying containers there were not in valid state was in kubelet at some point: kubernetes/kubernetes#98509