Skip to content

Move docker reference logic to reference/docker package #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2022
Merged

Move docker reference logic to reference/docker package #7007

merged 1 commit into from
Jun 1, 2022

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Jun 1, 2022

reference package should not export Docker-inherited reference logic, the reference/docker package is for that. The reference package has a smaller and less opinionated scope.

@dmcgowan
Move docker reference logic to reference/docker package
8ed5484 
Signed-off-by: Derek McGowan <derek@mcg.dev>
estesp
estesp approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit fcd0c86 into containerd:main Jun 1, 2022
@thaJeztah thaJeztah mentioned this pull request Nov 7, 2022
Merged
@dmcgowan dmcgowan deleted the move-docker-sort branch April 20, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmcgowan @kzys @samuelkarp @estesp