Skip to content

Conversation

mxpv
Copy link
Member

@mxpv mxpv commented Jan 12, 2023

Follow up for #7928
We should expose Go types in interfaces instead of using generated API.
This PR replaces types.Platform with specs Platform.

I will follow up with Controller changes separately.

Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@mxpv
Copy link
Member Author

mxpv commented Jan 12, 2023

/test pull-containerd-sandboxed-node-e2e

@mxpv mxpv added area/cri Container Runtime Interface (CRI) easy-to-review Easy to review labels Jan 12, 2023
@mxpv mxpv added this to the 1.7 milestone Jan 12, 2023
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit a43d719 into containerd:main Jan 12, 2023
@mxpv mxpv deleted the oci branch January 13, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cri Container Runtime Interface (CRI) easy-to-review Easy to review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants