Skip to content

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

release go1.19

go1.18.10 (released 2023-01-10) includes fixes to cgo, the compiler, the linker, and the crypto/x509, net/http, and syscall packages. See the [Go 1.18.10 milestone](https://github.com/golang/go/issues?q=milestone%3AGo1.18.10+label%3ACherryPickApproved) on our issue tracker for details.

and

go1.19.5 (released 2023-01-10) includes fixes to the compiler, the linker, and the crypto/x509, net/http, sync/atomic, and syscall packages. See the [Go 1.19.5 milestone](https://github.com/golang/go/issues?q=milestone%3AGo1.19.5+label%3ACherryPickApproved) on our issue tracker for details.

Signed-off-by: yanggang <gang.yang@daocloud.io>
@k8s-ci-robot
Copy link

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estesp
Copy link
Member

estesp commented Jan 10, 2023

Might have to wait a few hours for the DockerHub base image for golang to be updated to 1.19.5:

Resolving "golang" using unqualified-search registries (/etc/containers/registries.conf)
Trying to pull docker.io/library/golang:1.19.5...
Error: creating build container: initializing source docker://golang:1.19.5: reading manifest 1.19.5 in docker.io/library/golang: manifest unknown: manifest unknown

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Member

estesp commented Jan 11, 2023

/ok-to-test

@fuweid fuweid merged commit bbcfbf2 into containerd:main Jan 12, 2023
@yanggangtony yanggangtony deleted the go-version branch November 25, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants