Skip to content

Cleanup sandbox interfaces #7576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

Cleanup sandbox interfaces #7576

merged 1 commit into from
Oct 25, 2022

Conversation

mxpv
Copy link
Member

@mxpv mxpv commented Oct 22, 2022

This PR cleans up sandbox interfaces

  • Removes functions currently not used by CRI (it's easier to add them later once there will be a real use case for them).
  • Splits Controller.Start into Create + Start. For shims, Create call launches a new shim process instance, so it makes sense to decouple it from Start.

Signed-off-by: Maksym Pavlenko mxpv@apple.com

@mxpv mxpv force-pushed the sb branch 2 times, most recently from b3d5325 to 6e46e8e Compare October 22, 2022 03:19
@containerd containerd deleted a comment from k8s-ci-robot Oct 22, 2022
@containerd containerd deleted a comment from k8s-ci-robot Oct 22, 2022
@mxpv
Copy link
Member Author

mxpv commented Oct 22, 2022

/test pull-containerd-sandboxed-node-e2e

@dcantah dcantah self-assigned this Oct 22, 2022
@mxpv mxpv mentioned this pull request Oct 25, 2022
Closed
17 tasks
dcantah
dcantah reviewed Oct 25, 2022
View reviewed changes
dcantah
dcantah approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@dcantah dcantah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bit of feedback, LGTM

cpuguy83
cpuguy83 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @dcantah's comments

@mxpv
Cleanup sandbox interfaces
b7d0d12 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@mxpv mxpv added this to the 1.7 milestone Oct 25, 2022
@estesp estesp merged commit fc89d49 into main Oct 25, 2022
@mxpv mxpv deleted the sb branch October 25, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

@dcantah dcantah

Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mxpv @cpuguy83 @estesp @dcantah