Skip to content

CRI: implement Controller.Delete for SandboxAPI #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2022
Merged

CRI: implement Controller.Delete for SandboxAPI #7457

merged 1 commit into from
Oct 23, 2022

Conversation

wllenyj
Copy link
Contributor

@wllenyj wllenyj commented Sep 30, 2022

This pr is Sansbox API work in #7312. Implemented Controller.Delete.

Signed-off-by: wanglei01 wllenyj@linux.alibaba.com

@k8s-ci-robot
Copy link

Hi @wllenyj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wllenyj
CRI: implement Controller.Delete for SandboxAPI
a59ecc5 
Signed-off-by: WangLei <wllenyj@linux.alibaba.com>
@mxpv mxpv added this to the 1.7 milestone Sep 30, 2022
fuweid
fuweid reviewed Oct 1, 2022
View reviewed changes
@mxpv
Copy link
Member

mxpv commented Oct 4, 2022

/test pull-containerd-sandboxed-node-e2e

@samuelkarp samuelkarp added the area/cri Container Runtime Interface (CRI) label Oct 5, 2022
@mxpv mxpv mentioned this pull request Oct 10, 2022
Closed
17 tasks
@mxpv
Copy link
Member

mxpv commented Oct 22, 2022

@fuweid LGTY? Would be nice to get this in before betas.

mradyd918 referenced this pull request Oct 22, 2022
@wllenyj
CRI: implement Controller.Wait for SandboxAPI
9279069 
Rework sandbox monitoring, we should rely on Controller.Wait instead of
CRIService.StartSandboxExitMonitor

Signed-off-by: WangLei <wllenyj@linux.alibaba.com>
@fuweid fuweid merged commit 52025b5 into containerd:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

@fuweid fuweid fuweid approved these changes

+1 more reviewer

@sparr sparr sparr left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/cri Container Runtime Interface (CRI) needs-ok-to-test
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@wllenyj @k8s-ci-robot @mxpv @sparr @fuweid @samuelkarp