-
Notifications
You must be signed in to change notification settings - Fork 3.6k
CRI: cleanup cri/store package #6993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit about extra word in error message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just the nit on the error msg
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@mikebrow ptal; looks like your comment was addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Move out some code from
cri/store
package:reference
packagetrunkindex
(a general 'index tree') topkg/
Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com