Skip to content

Conversation

mxpv
Copy link
Member

@mxpv mxpv commented May 26, 2022

Move out some code from cri/store package:

  • Allow reading OCI image spec from client
  • Move reference sorting to reference package
  • Move trunkindex (a general 'index tree') to pkg/
  • Remove deprecated error types (that were scheduled for removal in 1.5)

Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com

mxpv added 3 commits May 26, 2022 12:38
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@mxpv mxpv changed the title Test CRI: cleanup cri/store May 26, 2022
@mxpv mxpv changed the title CRI: cleanup cri/store CRI: cleanup cri/store package May 26, 2022
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit about extra word in error message

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just the nit on the error msg

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@thaJeztah
Copy link
Member

thaJeztah commented May 31, 2022

@mikebrow ptal; looks like your comment was addressed

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 8c27ce4 into containerd:main Jun 1, 2022
@mxpv mxpv deleted the images branch June 2, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants