Skip to content

systemd: use LimitNOFILE=infinity instead of hard-coded max value #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2020
Merged

systemd: use LimitNOFILE=infinity instead of hard-coded max value #4475

merged 1 commit into from
Aug 17, 2020

Conversation

thaJeztah
Copy link
Member

According to the systemd documentation, infinity can be used for all limits;
https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Properties

Resource limits may be specified in two formats: either as single value to set a
specific soft and hard limit to the same value, or as colon-separated pair soft:hard
(...) Use the string infinity to configure no limit on a specific resource.

@thaJeztah
systemd: use LimitNOFILE=infinity instead of hard-coded max value
c691c36 
According to the systemd documentation, `infinity` can be used for all limits;
https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Properties

> Resource limits may be specified in two formats: either as single value to set a
> specific soft and hard limit to the same value, or as colon-separated pair soft:hard
> (...) Use the string infinity to configure no limit on a specific resource.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 13, 2020

Build succeeded.

@dims
Copy link
Member

dims commented Aug 13, 2020

LGTM 👍

@thaJeztah
Copy link
Member Author

Given that the purpose of these is to disable accounting, I was also looking at the XXAccounting options instead (see docker/for-linux#73). IOW, instead of setting to "unlimited", disable accounting altogether.

I'm not sure if that has the same effect though, so if anyone knows someone with more Systemd experience/insight, input welcome!

dmcgowan
dmcgowan approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fuweid
fuweid approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 6c74c39 into containerd:master Aug 17, 2020
@thaJeztah thaJeztah deleted the minor_systemd_updates branch August 17, 2020 17:58
@BenTheElder BenTheElder mentioned this pull request Aug 21, 2020
Merged
@Loyalsoldier Loyalsoldier mentioned this pull request Apr 29, 2021
Merged
@drigz drigz mentioned this pull request Oct 15, 2021
Closed
@ssaaiidd ssaaiidd mentioned this pull request Mar 23, 2022
Closed
@thaJeztah thaJeztah mentioned this pull request Apr 2, 2022
Closed
@GerardoGR GerardoGR mentioned this pull request Jun 10, 2022
Closed
1 task
@chaen chaen mentioned this pull request Jun 22, 2022
Merged
rayburgemeestre added a commit to rayburgemeestre/containerd that referenced this pull request Oct 20, 2022
@rayburgemeestre
Revert "Merge pull request containerd#4475 from thaJeztah/minor_syste…
efb4b88 
…md_updates"

This reverts commit 6c74c39, reversing
changes made to 09814d4.
@rayburgemeestre rayburgemeestre mentioned this pull request Oct 20, 2022
Closed
rayburgemeestre added a commit to rayburgemeestre/containerd that referenced this pull request Oct 20, 2022
@rayburgemeestre
Revert "Merge pull request containerd#4475 from thaJeztah/minor_syste…
d33b2a6 
…md_updates"

This reverts commit 6c74c39, reversing
changes made to 09814d4.

Signed-off-by: Ray Burgemeestre <rayb@nvidia.com>
@gpl gpl mentioned this pull request Feb 23, 2023
Closed
@faiq faiq mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @dims @dmcgowan @fuweid