Add distribution subpkgs to core #3728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: containerd#3554 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
Can we remove this from vendor now too? |
|
Build succeeded.
|
|
@jterry75 not yet, i'll have to merge this one and then update CRI |
Codecov Report
@@ Coverage Diff @@
## master #3728 +/- ##
==========================================
+ Coverage 42.1% 42.13% +0.03%
==========================================
Files 129 131 +2
Lines 14307 14474 +167
==========================================
+ Hits 6024 6099 +75
- Misses 7383 7467 +84
- Partials 900 908 +8
Continue to review full report at Codecov.
|
Oh the stepchild CRI :) |
|
Note: looks like this needed |
zhsj
added a commit
to zhsj/cri
that referenced
this pull request
Apr 13, 2020
Since containerd/containerd#3728 The docker/distribution/reference package is copied into containerd core Signed-off-by: Shengjing Zhu <i@zhsj.me>
zhsj
added a commit
to zhsj/cri
that referenced
this pull request
Apr 15, 2020
Since containerd/containerd#3728 The docker/distribution/reference package is copied into containerd core Signed-off-by: Shengjing Zhu <i@zhsj.me>
This was referenced Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3554
Ports over some of the distribution/* packages into the containerd to core so that we reduce that dependency.
Signed-off-by: Michael Crosby crosbymichael@gmail.com