Skip to content

cmd/ctr: allow user to syncfs during unpacking image locally #11118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

cmd/ctr: allow user to syncfs during unpacking image locally #11118

merged 1 commit into from
Dec 11, 2024
+39 −11

Conversation

tboevil
Copy link
Contributor

@tboevil tboevil commented Dec 9, 2024 •
edited
Loading

this commit Added sync-fs support for cri interface, but not ctr.
this commit Added global configuration but not flexible enough.

@fuweid PTAL

@tboevil
cmd: add syncfs option to ctr command
11b7825 
Signed-off-by: Qiyuan Liang <qiyuan.liang@smartx.com>
@k8s-ci-robot
Copy link

Hi @tboevil. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tboevil tboevil mentioned this pull request Dec 9, 2024
Merged
@fuweid fuweid changed the title cmd: add syncfs option to ctr command cmd/ctr: allow user to syncfs during unpacking image Dec 11, 2024
fuweid
fuweid approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change only works for client-side unpack. For transfer service, we can file following pull request to handle that.

@fuweid fuweid changed the title cmd/ctr: allow user to syncfs during unpacking image cmd/ctr: allow user to syncfs during unpacking image locally Dec 11, 2024
@mxpv mxpv added this pull request to the merge queue Dec 11, 2024
Merged via the queue into containerd:main with commit ff4f5cb Dec 11, 2024
56 checks passed
This was referenced Jan 16, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tboevil @k8s-ci-robot @mxpv @fuweid