Skip to content

Make StopPodSandbox RPC idempotent #10520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

Make StopPodSandbox RPC idempotent #10520

merged 1 commit into from
Jul 30, 2024

Conversation

saschagrunert
Copy link
Contributor

Similar to sandbox removal, the stop of a sandbox should be a noop if the sandbox has not been found.

Found during: kubernetes-sigs/cri-tools#1535

@saschagrunert
Make StopPodSandbox RPC idempotent
c6cea95 
Similar to sandbox removal, the stop of a sandbox should be a noop if
the sandbox has not been found.

Found during: kubernetes-sigs/cri-tools#1535

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot
Copy link

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added area/cri Container Runtime Interface (CRI) kind/feature labels Jul 30, 2024
This was referenced Jul 30, 2024
Merged
Merged
@mxpv mxpv added this pull request to the merge queue Jul 30, 2024
Merged via the queue into containerd:main with commit fec24e2 Jul 30, 2024
44 checks passed
@samuelkarp samuelkarp added cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 30, 2024
@saschagrunert saschagrunert deleted the cri branch July 31, 2024 06:56
@saschagrunert
Copy link
Contributor Author

/cherrypick release/1.6

@saschagrunert
Copy link
Contributor Author

/cherrypick release/1.7

@k8s-infra-cherrypick-robot
Copy link

@saschagrunert: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@saschagrunert: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jul 31, 2024
Merged
Merged
@samuelkarp samuelkarp added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/sbserver Changes are backported to sbserver cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
area/cri Container Runtime Interface (CRI) cherry-picked/sbserver Changes are backported to sbserver cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch kind/feature needs-ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saschagrunert @k8s-ci-robot @k8s-infra-cherrypick-robot @mxpv @fuweid @samuelkarp