Skip to content

[core] sandbox recording should be in v1 bucket #10467

New issue
New issue
Closed
Closed
[core] sandbox recording should be in v1 bucket#10467
Labels
kind/bug
Milestone
2.0
@fuweid

Description

@fuweid
fuweid
opened on Jul 16, 2024

Description

All kind of resources should be in v1 bucket in metadata database.
However, sandbox type isn't in v1 bucket. It's not aligned to metadata design.

containerd/core/metadata/buckets.go

Lines 17 to 31 in ac818cb

// Package metadata stores all labels and object specific metadata by namespace.
// This package also contains the main garbage collection logic for cleaning up
// resources consistently and atomically. Resources used by backends will be
// tracked in the metadata store to be exposed to consumers of this package.
//
// The layout where a "/" delineates a bucket is described in the following
// section. Please try to follow this as closely as possible when adding
// functionality. We can bolster this with helpers and more structure if that
// becomes an issue.
//
// Generically, we try to do the following:
//
// <version>/<namespace>/<object>/<key> -> <field>
//
// version

containerd/core/metadata/buckets.go

Lines 309 to 315 in 67a0efc

func getSandboxBucket(tx *bolt.Tx, namespace string) *bolt.Bucket {
return getBucket(
tx,
[]byte(namespace),
bucketKeyObjectSandboxes,
)
}

Steps to reproduce the issue

  1. create pod by crictl

Describe the results you received and expected

The sandbox type should be in v1 bucket.

What version of containerd are you using?

main

Any other relevant information

No response

Show configuration if it is related to CRI plugin.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bug

    Type

    No type

    Projects

    containerd v2 blockers

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions