Skip to content

Check all .condarc files when removing defaults #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcoesters
Copy link
Contributor

Miniconda recently added defaults to the .condarc file in the installation root directory. This causes the feature to remove defaults from the channels list to fail (see Example 14) because setup-miniconda assumes that the defaults channel is only inside ~/.condarc.

This PR adds a more robust check to remove defaults from all .condarc files.

@jezdez
Copy link
Member

jezdez commented May 6, 2025

You'll need to build the distribution of the typescript library following the process in CONTRIBUTING.md so it shows up in dist/

@marcoesters
Copy link
Contributor Author

marcoesters commented May 6, 2025

You'll need to build the distribution of the typescript library following the process in CONTRIBUTING.md so it shows up in dist/

I missed them when adding them to staging because I use git add -p, but something looks wrong.

@jezdez jezdez changed the base branch from main to semver May 6, 2025 20:28
@marcoesters marcoesters marked this pull request as ready for review May 6, 2025 20:35
@marcoesters marcoesters requested a review from a team as a code owner May 6, 2025 20:35
@jezdez jezdez merged commit 6e9a4af into conda-incubator:semver May 6, 2025
89 checks passed
@marcoesters marcoesters deleted the remove-defaults-everywhere branch May 6, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants