use normal builds on unix #20
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Note that all the patches were integrated upstream. |
|
The buggy CMake files for zeromq are again responsible for major issues like conda-forge/pyzmq-feedstock#27. I'm going to revive this PR, because libzmq CMake appears like it should ~never be used and regularly produces invalid libraries. |
generate cmake files ourselves as a compromise
dylib.5 is not correct
not the git archive, the actual release
|
Also previous builds of 4.2.3 on linux/mac should be marked as broken after merge (or immediately), since they create incorrect libraries. |
cmake is clearly not well supported, since it doesn’t work from releases
There was a problem hiding this comment.
We posted a lengthy answer about the move to configure + make here.
#25
it’s part of a standard install, test it
cmake runs files multiple times, so has to check if targets have been defined before defining them.
|
Thanks! Travis is having major backlog issues (on all platforms now), so hopefully this will get published eventually. |
|
Thanks for all the work you've put in this (both libzmq and xeus stack)! I'll make a conda package for cppzmq 4.2.3 as soon as this is published. |
uses regular build system, rather than the relatively unused cmake builds, which require many patches and don't work reliably.
generate cmake files as a compromise for downstream projects that seem to rely on them.
fixes #20