Skip to content

Conversation

hadim
Copy link
Member

@hadim hadim commented Jul 31, 2020

…to properly catch JSONDecodeError

Checklist

  • Added a news entry

@scopatz
Copy link
Member

scopatz commented Aug 1, 2020

Doesn't JSONDecodeError come from the standard library?

@hadim
Copy link
Member Author

hadim commented Aug 1, 2020

The one from json yes. But requests when available uses simplejson. In consequence the JSONDecodeError error can come from both json or simplejson. Even if the errors have the same name, they are different objects (since they come from two different libs).

@hadim
Copy link
Member Author

hadim commented Aug 1, 2020

So without this PR an error will be raised during rendering if your env contains simplejson.

@scopatz scopatz merged commit 71af5bd into conda-forge:master Aug 1, 2020
@scopatz
Copy link
Member

scopatz commented Aug 1, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants