Use mamba 2 for the base installation of Miniforge (continued) #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
commented
Mar 5, 2025
hmaarrfk
reviewed
Mar 5, 2025
| @@ -1,9 +1,9 @@ | |||
| {% set version = os.environ.get("MINIFORGE_VERSION", "24.11.3-0") %} | |||
| {% set conda_libmamba_solver_version = "24.9.0"%} | |||
| # This file is parsed by the scripts to define | |||
There was a problem hiding this comment.
i would rather keep this "intelligent" parsing. if possible.
I don't want to update a file in 3 locations since it makes using bots difficult.
There was a problem hiding this comment.
I am also in favor of keeping it, but I was not working last time (I guess it depends on the current working directory).
There was a problem hiding this comment.
ah thnaks for working through it.
yeah it might be a little fragile i guess.
hmaarrfk
reviewed
Mar 5, 2025
hmaarrfk
reviewed
Mar 5, 2025
hmaarrfk
reviewed
Mar 5, 2025
hmaarrfk
reviewed
Mar 5, 2025
This reverts commit d55cfd6.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
The previous commands do not parse the version successfully. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
SylvainCorlay
approved these changes
Mar 11, 2025
|
let merge and create a pre-release for us to test. and we can report results. |
hmaarrfk
reviewed
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #715.