Skip to content

Release 24.11.3 2 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

Release 24.11.3 2 #741

merged 2 commits into from
Mar 12, 2025

Conversation

hmaarrfk
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

hmaarrfk added 2 commits March 12, 2025 16:52
@hmaarrfk
Revert "Merge pull request conda-forge#728 from jjerphan/use-mamba-2"
86eab91 
This reverts commit 06d2e3f, reversing
changes made to cad3155.
@hmaarrfk
Release 24.11.3-2
ae17efa 
Same thing but working around fmt11 release issues of fmt 11.1

PR for mamba2 incoming after the release of 24.11.3-2
@hmaarrfk hmaarrfk requested a review from a team as a code owner March 12, 2025 20:53
@hmaarrfk hmaarrfk mentioned this pull request Mar 12, 2025
Closed
@SylvainCorlay
Copy link
Member

Ad discussed here, I am fine having a release with mamba 1 including the constructor fixes before having another stab at mamba 2.

@hmaarrfk
Copy link
Contributor Author

I still see 11.1 in the build. is that ok?

@jjerphan
Copy link
Member

jjerphan commented Mar 12, 2025 •
edited
Loading

I still see 11.1 in the build. is that ok?

For now 11.1 being picked is normal but not OK1.

We probably should wait for a pathway as being discussed in: conda-forge/admin-requests#1433 (comment).

Footnotes

  1. Builds of fmt>=11.1 are still present (not yet marked broken) and the adaptation for projects depending on fmt have not been performed yet. ↩

@SylvainCorlay
Copy link
Member

I still see 11.1 in the build. is that ok?

For now 11.1 being picked is normal but not OK1.

We probably should wait for a pathway as being discussed in: conda-forge/admin-requests#1433 (comment).

Footnotes

  1. Builds of fmt>=11.1 are still present (not yet marked broken) and the adaptation for projects depending on fmt have not been performed yet. ↩

conda-forge/admin-requests#1433 has been merged. Hopefully, 11.1 should not be picked up anymore.

@hmaarrfk hmaarrfk closed this Mar 12, 2025
@hmaarrfk hmaarrfk reopened this Mar 12, 2025
jjerphan
jjerphan approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (this should create the same installers as the one of 24.11.3-1 made with #737 taking builds of fmt<11.1).

@hmaarrfk
Copy link
Contributor Author

fmt 11.1.4 is ok?

@jjerphan
Copy link
Member

No, fmt<11.1 have to be used.

Is one of the installer mentioning fmt>=11.1 builds?

@hmaarrfk hmaarrfk closed this Mar 12, 2025
@hmaarrfk hmaarrfk reopened this Mar 12, 2025
@hmaarrfk
Copy link
Contributor Author

yes the linux x86_64 build was. Lets try to rebuild again.

@hmaarrfk
Copy link
Contributor Author

ok fmt 11.0 got pulled in.

@hmaarrfk hmaarrfk merged commit 36889b9 into conda-forge:main Mar 12, 2025
24 checks passed
hmaarrfk added a commit to hmaarrfk/miniforge that referenced this pull request Mar 12, 2025
@hmaarrfk
Revert "Merge pull request conda-forge#741 from hmaarrfk/release_24.1…
86e3280 
…1.3-2"

This reverts commit 36889b9, reversing
changes made to 06d2e3f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmaarrfk @SylvainCorlay @jjerphan