Ensure compatibility with libmamba 1.0 and conda 22.11 #78
Conversation
|
Python 3.7 tests will fail because Otherwise we can also drop 3.7 from the matrix, but I think this is still supported by Anaconda so... let's wait :) |
| channel_name = "defaults" | ||
|
|
||
| # only check the loaded index if it contains the channel conda should come from | ||
| # otherwise ignore | ||
| index_channels = {getattr(chn, "canonical_name", chn) for chn in index._channels} | ||
| if channel_name in index_channels: | ||
| if channel_name not in index_channels: |
There was a problem hiding this comment.
Apparently we had this logic reversed 😨
This now will indeed check where there's a conda update if the solution includes conda, and we happened to have the channel conda came from in the loaded channels already (to prevent additional fetching).
There was a problem hiding this comment.
Yikes, that seems bad, will take a closer look at what that means..
| @@ -757,13 +757,13 @@ def _notify_conda_outdated( | |||
| return | |||
|
|
|||
| channel_name = current_conda_prefix_rec.channel.canonical_name | |||
| if channel_name == UNKNOWN_CHANNEL: | |||
| if channel_name in (UNKNOWN_CHANNEL, "@", "<develop>", "pypi"): | |||
There was a problem hiding this comment.
Fixes a query issue when we are checking whether a conda update is available, but its source channel is "develop" because it was installed in dev mode. I added other commonly used fake channels just in case.
There was a problem hiding this comment.
Will this @ here stumble over authentication passed in?
c54701d to
19c1d35
Compare
|
@jaimergp we're down to one error: |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Fixes #57.