-
Notifications
You must be signed in to change notification settings - Fork 29
Load repodata from historically used channels (as stored in PrefixData
)
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See https://github.com/conda/conda/issues/11790 | ||
""" | ||
with make_temp_env("conda-forge::xz", "python") as prefix: | ||
output = check_output( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note we need a whole subprocess here because libmamba prints to STDERR directly, and that won't be intercepted with our naïve in-process capturing mechanisms.
PrefixData
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, just a minor note about hard-coding the pseudo channel names. Thank you @jaimergp!
# skip if the channel has authentication info, because | ||
# it might cause issues with expired tokens and what not | ||
continue | ||
if record.channel.name in ("@", "<develop>", "pypi"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if we have a definite list of these pseudo channel names in conda that we don't have to hard-code it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked but I couldn't find it. Looks like they were added as needed for edge cases found during the development of orthogonal features. @
is for virtual channels, <develop>
seems to come from pip install -e
and pypi
is found for pip install
that do not have a conda-meta
entry, as far as I can understand.
@jezdez Should we port this over to |
Closes conda/conda#11790
I am not sure whether we should go this way, though. I think it's a good idea, but we also need to enable this on
conda/conda
,mamba
andmicromamba
for better compatibility across the ecosystem.Authenticated channels are the only blocker here, but it can be either worked around or handled gracefully with good errors.