Skip to content

Warn if parsed and raw outputs mismatch #5601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 15, 2025
Merged

Warn if parsed and raw outputs mismatch #5601

merged 9 commits into from
Feb 15, 2025

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 25, 2025 •
edited
Loading

Description

See #5571 (comment)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 25, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5601 will not alter performance

Comparing jaimergp:assert-outputs-jinja (2fdce8c) with main (abd7c1d)

Summary

✅ 5 untouched benchmarks

@jaimergp jaimergp marked this pull request as ready for review January 26, 2025 19:51
@jaimergp jaimergp requested a review from a team as a code owner January 26, 2025 19:51
beckermr
beckermr requested changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this should have a test. That way we have a test case to use to attempt to fix the underlying issue.

@jaimergp
Copy link
Contributor Author

Added.

@beckermr beckermr enabled auto-merge (squash) February 14, 2025 12:33
@jaimergp
Copy link
Contributor Author

jaimergp commented Feb 15, 2025 •
edited
Loading

I'll open a PR to skip the failing tests for now. See #5601

@beckermr beckermr merged commit 74dc428 into conda:main Feb 15, 2025
28 checks passed
@kenodegard kenodegard mentioned this pull request Mar 17, 2025
Closed
59 tasks
isuruf
isuruf reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this log a warning for all recipes without an outputs section?

@jaimergp
Copy link
Contributor Author

True:

WARNING: Number of parsed outputs does not match detected raw metadata blocks. Identified output block may be wrong! If you are using Jinja conditionals to include or exclude outputs, consider using `skip: true  # [condition]` instead.

I'll open an issue to track.

@jaimergp jaimergp mentioned this pull request Mar 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaimergp @isuruf @beckermr @conda-bot