Skip to content

Require conda-libmamba-solver 25.4 or greater to fix issue with spaces in CONDA_BLD_PATH #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
May 3, 2025
Merged

Require conda-libmamba-solver 25.4 or greater to fix issue with spaces in CONDA_BLD_PATH #5675

merged 29 commits into from
May 3, 2025

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Apr 3, 2025 •
edited
Loading

Description

Checking mamba-org/mamba#3730

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Apr 3, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 3, 2025
This was referenced Apr 3, 2025
Closed
Merged
@jaimergp jaimergp moved this to In Progress 🏗️ in Quansight <> Anaconda 2025 Apr 3, 2025
@jaimergp
Copy link
Contributor Author

jaimergp commented Apr 4, 2025

With the fixes in conda/conda-libmamba-solver#640, tests/test_api_build.py::test_croot_with_spaces does pass:

[gw1] [ 12%] PASSED tests/test_api_build.py::test_croot_with_spaces

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5675 will not alter performance

Comparing jaimergp:debug-winslashes (1bbc9d9) with main (1e6a2a1)

Summary

✅ 5 untouched benchmarks

@jaimergp
Copy link
Contributor Author

Sounds like this is fixed with CLS 25.4.0. Not sure what we want to do with the xfail. Remove it? I don't know why the py39 CI fails to solve 🤔

@beckermr
Copy link
Contributor

Maybe we bump the 23.7.0 conda requirement in the CI to 25.4?

@beckermr
Copy link
Contributor

@jaimergp which xfail do you mean?

@beckermr
Copy link
Contributor

pre-commit.ci autofix

@beckermr
Copy link
Contributor

This entrypoint error is insane.

@jaimergp
Copy link
Contributor Author

jaimergp commented May 1, 2025

This entrypoint error is insane.

That's probably the latest setuptools. That deprecation has been pushed back in 80.1, so we just need a package update.

@jaimergp
Copy link
Contributor Author

jaimergp commented May 1, 2025

@jaimergp which xfail do you mean?

Ah sorry, meant this skipif.

@beckermr
Copy link
Contributor

beckermr commented May 1, 2025

Yes we should remove the skipif since it passes now and we always want it to pass.

@beckermr
Copy link
Contributor

beckermr commented May 1, 2025

pre-commit.ci autofix

beckermr
beckermr reviewed May 2, 2025
View reviewed changes
beckermr
beckermr reviewed May 2, 2025
View reviewed changes
beckermr
beckermr reviewed May 2, 2025
View reviewed changes
beckermr
beckermr reviewed May 2, 2025
View reviewed changes
beckermr
beckermr reviewed May 2, 2025
View reviewed changes
@beckermr
Copy link
Contributor

beckermr commented May 2, 2025

OK @jaimergp - beyond flaky test failures, this PR should be fixed up and good to go!

@jaimergp jaimergp changed the title Debug test_croot_with_spaces with conda-forge Require conda-libmamba-solver 25.4 or greater to fix issue with spaces in CONDA_BLD_PATH May 3, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Approved in 🔎 Review May 3, 2025
@beckermr beckermr marked this pull request as ready for review May 3, 2025 14:29
@beckermr beckermr requested a review from a team as a code owner May 3, 2025 14:29
@beckermr beckermr merged commit 239b07a into conda:main May 3, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review May 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done 💪🏾 in Quansight <> Anaconda 2025 May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Quansight <> Anaconda 2025
Archived in project
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaimergp @beckermr @conda-bot