Skip to content

test: regression tests for bugs in 5645 and 5644 #5648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 24, 2025
Merged

test: regression tests for bugs in 5645 and 5644 #5648

merged 17 commits into from
Mar 24, 2025

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Mar 21, 2025 •
edited
Loading

Description

This PR adds a test for the regressions reported in #5645 and #5644.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Extra items

The test failures in #5649 are:

FAILED tests/test_api_build.py::test_api_build_grpc_issue5632 - conda_libmamba_solver.conda_build_exceptions.ExplainedDependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {MatchSpec("python==3.11[build=*_cpython]")}
Encountered problems while solving:
  - unsupported request

Could not solve for environment specs
The following package could not be installed
└─ python =3.11,(>=3.10,<3.11.0a0) *_cpython does not exist (perhaps a typo or a missing channel).

This is the correct failure due to the conflicting python specs.

The other test failure for #5644 that I get locally looks correct too:

FAILED

================================================================================ FAILURES ================================================================================
__________________________________________________________________ test_api_build_pytorch_cpu_issue5644 __________________________________________________________________

Traceback (most recent call last):
  File "/Users/beckermr/mambaforge/envs/cf-dev/lib/python3.11/site-packages/conda/models/version.py", line 44, in __call__
    return cls._cache_[arg]
           ~~~~~~~~~~~^^^^^
KeyError: '>=3.10,<3.11.0a0'
...
conda.exceptions.InvalidVersionSpec: Invalid version '>=3.10,<3.11.0a0': invalid character(s)

This looks correct relative to the original issue, but is for a different python version which is fine. I will check back on the CI version in a bit to ensure that works as well.

Yep the test failure is correct:

FAILED tests/test_api_build.py::test_api_build_pytorch_cpu_issue5644 - conda.exceptions.InvalidVersionSpec: Invalid version '>=3.10,<3.11.0a0': invalid character(s)

pre-commit-ci bot and others added 7 commits March 17, 2025 11:52
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (#5641)
3f06913 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.0](astral-sh/ruff-pre-commit@v0.9.10...v0.11.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kenodegard
Merge pull request #5643 from conda/25.3.x
834448b 
Merge `25.3.x` back into `main`
@jaimergp
Revert "Fix transitive subpackage dependency resolution (#5603)"
a519df2 
This reverts commit 49872a5, but keeping tests
@jaimergp
add news
b1538f7
@jaimergp
xfail test
66ccb2a
@jaimergp
pre-commit
01f2aaf
@beckermr
test: add test for grpc regression
0b4abab
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Mar 21, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 21, 2025
@beckermr beckermr changed the title Regr tests test: regression tests for bugs in 5645 and 5644 Mar 21, 2025
@beckermr beckermr mentioned this pull request Mar 21, 2025
Closed
@beckermr beckermr changed the base branch from main to 25.3.x March 21, 2025 21:40
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5648 will not alter performance

Comparing regr-tests (8c88aed) with 25.3.x (e77c4c6)

Summary

✅ 5 untouched benchmarks

@beckermr beckermr marked this pull request as ready for review March 22, 2025 11:59
@beckermr beckermr requested a review from a team as a code owner March 22, 2025 11:59
@beckermr
Copy link
Contributor Author

@conda/builds-tools This PR is ready for review!

@beckermr beckermr mentioned this pull request Mar 22, 2025
Merged
3 tasks
@isuruf isuruf enabled auto-merge (squash) March 24, 2025 12:31
@isuruf
Copy link
Contributor

isuruf commented Mar 24, 2025

Thanks

@beckermr
Copy link
Contributor Author

If you approve the pr @isuruf, we can merge and then check your fix against the new tests.

@isuruf isuruf merged commit 70e79f2 into 25.3.x Mar 24, 2025
28 checks passed
@isuruf isuruf deleted the regr-tests branch March 24, 2025 12:55
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🔎 Review Mar 24, 2025
@isuruf
Copy link
Contributor

isuruf commented Mar 24, 2025

Ah, that's what github was waiting for

This was referenced Apr 2, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beckermr @isuruf @conda-bot @kenodegard @jaimergp