Skip to content

get_conda_operation_locks call in environ.py wrong #4215

@tholam

Description

@tholam

Actual Behavior

conda_build.utils.get_conda_operation_locks had its signature updated some time ago but one of the calls to it wasn't updated to account for that

55eca10#diff-c54c378feea1d475af4a7c30e9be71e40de70f98c5e804e50e8c676569496f8aL326-R336

if not locks:
locks = utils.get_conda_operation_locks(config)
try:

Expected Behavior

I think the call should probably look something like this based on what's passed to the get_conda_operation_locks call in conda_build.environ.get_install_actions

locks = utils.get_conda_operation_locks(config.locking, tuple(config.bldpkgs_dirs), config.timeout)

I found this while trying to see if/how conda and conda build prevents race conditions in the package cache and am unsure if it actually causes any issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    locked[bot] locked due to inactivitystale[bot] marked as stale due to inactivitystale::closed[bot] closed after being marked as stale

    Type

    No type

    Projects

    Status

    🏁 Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions